Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gulp 4.0.0-alpha.3 can't parse config bundle file #103

Closed
itlessons opened this issue Dec 25, 2017 · 1 comment
Closed

Gulp 4.0.0-alpha.3 can't parse config bundle file #103

itlessons opened this issue Dec 25, 2017 · 1 comment

Comments

@itlessons
Copy link

itlessons commented Dec 25, 2017

After update to Gulp 4.0.0-alpha.3 code throw error:

Failed to parse config file: /path/bundle.config.js
Error: Configuration file should be in the form "{ bundle: {}, copy: {} }"
at new Config (/path/node_modules/gulp-bundle-assets/lib/model/config.js:26:11)
at Writable._write (/path/node_modules/gulp-bundle-assets/index.js:38:16)
at doWrite (/path/node_modules/gulp-bundle-assets/node_modules/readable-stream/lib/_stream_writable.js:319:12)
at writeOrBuffer (/path/node_modules/gulp-bundle-assets/node_modules/readable-stream/lib/_stream_writable.js:305:5)
at Writable.write (/path/node_modules/gulp-bundle-assets/node_modules/readable-stream/lib/_stream_writable.js:232:11)
.....

If downgrade to Gulp 4.0.0-alpha.2 works fine like this:
"gulp": "github:gulpjs/gulp#6d71a65",

I guess need update vinyl to 2.1:
gulpjs/gulp#2065
gulpjs/vinyl-fs#288

@chmontgomery
Copy link
Contributor

gulp-bundle-assets was never intended to work with gulp 4. gulp-bundle-assets should still be using gulp 3 under the covers even if you're using a gulp 4 gulpfile. I bet there's a shared dependency that breaks things since I never shrinkwrapped (or package locked) this module.

I don't have any plans to update this module for gulp 4 support. sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants