-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
selectItemAtIndex possible regression #110
Comments
Your issue is we changed |
Thanks again for keeping up with the changes. Things are solidifying so hopefully you wont have to deal with this in the future 😄 |
@the-simian I think this also part of your problem #113 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Relevant code or config
Before I explain the issue, heres the chunk of code to look for in the demo to be able to reproduce the issue. (around line 131 of the material-combobox.js file)
Howdy! :) When I upgraded to
1.0.0-beta.21
from1.0.0-beta.14
, some issues such as the clearing of the autocomplete seem totally resolved and just about everything seems to be working well; however, I think two functions that are means to select items might have regressed (as they dont seem to work for me);So I have a function that fires
onClick
. When I use theselectItem
function, I can select the item directly, with no difficulty. However two functions,selectHighlightedItem
,selectItemAtIndex
might have regressed. looking at the code here: my first suspicion would be theselectItemAtIndex
, sinceselectHighlightedItem
(line 204) seems to depend onselectItemAtIndex
(line 192);Some important things to note:
onStateChange
and I can see that as I hover over items, and type, the state is properly changing correctly.selectHighlightedItem
, leading me to believe that it is probably fine itself.selectHighlightedItem
, which callsselectItemAtIndex
Its also possible I overlooked something obvious, and if I did, that won't surprise me at all :) I did my best to update this demo the right way, but if you think I made a mistake when I did, I appreciate the help.
Please let me know if I can add any more info :)
The text was updated successfully, but these errors were encountered: