Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: v7 #1415

Merged
merged 5 commits into from Oct 22, 2022
Merged

feat: v7 #1415

merged 5 commits into from Oct 22, 2022

Conversation

silviuaavram
Copy link
Collaborator

@silviuaavram silviuaavram commented Sep 25, 2022

BREAKING CHANGE: updates to useCombobox and useSelect to adhere to the 1.2 version of the ARIA Combobox pattern.

Migration guide is available in this file.

Closes #1365.
Closes #1239.
Contains changes from #1149.

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (4bffe16) compared to base (6bd18eb).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1415   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines         1692      1682   -10     
  Branches       489       501   +12     
=========================================
- Hits          1692      1682   -10     
Impacted Files Coverage Δ
src/hooks/reducer.js 100.00% <ø> (ø)
src/hooks/useCombobox/utils.js 100.00% <ø> (ø)
src/hooks/useSelect/utils.ts 100.00% <ø> (ø)
src/hooks/testUtils.js 100.00% <100.00%> (ø)
src/hooks/useCombobox/index.js 100.00% <100.00%> (ø)
src/hooks/useCombobox/reducer.js 100.00% <100.00%> (ø)
src/hooks/useCombobox/testUtils.js 100.00% <100.00%> (ø)
src/hooks/useMultipleSelection/testUtils.js 100.00% <100.00%> (ø)
src/hooks/useSelect/index.js 100.00% <100.00%> (ø)
src/hooks/useSelect/reducer.js 100.00% <100.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

* migration document to be changed

* state changes and types

* tests update

* wip useCombobox changes

* finish coding it up

* fix coverage, remove circularNavigation

* fixed cypress version

* update cypress preprocessor

* migration guide

* revert to autocomplete list

* code review
@silviuaavram silviuaavram merged commit 7540e3d into master Oct 22, 2022
@github-actions
Copy link

🎉 This PR is included in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aria 1.2 support for useSelect Aria 1.2 support for useCombobox
2 participants