fix(useCombobox): ensure highlighted item is not selected on browser tab change #1484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tab change Related issue - downshift-js#1471
silviuaavram
approved these changes
Mar 14, 2023
silviuaavram
changed the title
|
🎉 This PR is included in version 7.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
InputBlur action should return
selectedItemonly from Tab/Shift+Tab and not from clicking outside. However, before this change, if your click outside is to change browser tab, the currenthighlightedIndexis selected when returning to the page. This PR is to prevent that behaviour.Fixes #1471.
How:
This PR updates the
InputBlurhandler onuseComboboxto rely on theevent.relatedTarget. In a blur event, this is set to the element receiving focus which is simplynullwhen switching tabs because focus is no longer in that window.Checklist: