Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(useSelect): focus toggle when opened initially #1527

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

silviuaavram
Copy link
Collaborator

@silviuaavram silviuaavram commented Aug 2, 2023

What:
Focus the toggle element if the menu is opened initially.

Why:
Similar behaviour to useCombobox and the input focus.

How:
Same implementation as for useCombobox.

Checklist:

  • Documentation
  • Tests
  • TypeScript Types
  • Flow Types
  • Ready to be merged

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (883a458) 100.00% compared to head (3007bd5) 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1527   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines         1711      1715    +4     
  Branches       510       511    +1     
=========================================
+ Hits          1711      1715    +4     
Files Changed Coverage Δ
src/hooks/useSelect/index.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@silviuaavram silviuaavram merged commit 90d6d72 into master Aug 2, 2023
2 checks passed
@silviuaavram silviuaavram deleted the feat/initial-focus-use-select branch August 2, 2023 07:28
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

🎉 This PR is included in version 8.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants