New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Touch devices can swipe to see mobile menu when no hamburger #622
Comments
+1 Jeff Ascough ticket 160254 - when mobile menu is set to display "right", pinching to zoom on images can cause mobile menu to slide open |
Kind of feel like swipe to open is more trouble than its worth. We should consider making the hamburger just function as tap to open. |
As far as user experience goes, I don't think people KNOW you can swipe to show the menu. There's no indication that you can do it, and most people know to just tap the icon to open/close. I like the feature, but because of the update to iOS 10 which allows you to swipe left/right when you have multiple tabs open in the browser this can get glitchy anyway depending on where you first tap to swipe from, that glitchiness comes more from the phone than the iPad. |
You essentially can only swipe from the middle with that feature built into iOS10 now. I think originally me and Matt got the idea from back when Squarespace had this feature. They've since switched to an old school footer menu. If you can fix it, awesome, but I could go both ways it. |
Awesome. That is helpful. I'm going to vote for the chopping block personally 😈 - but of course ProPhoto is a democracy. |
+1 Eddie Bojorquez ticket 162941 - wants a way to disable swipe to open mobile menu |
+1 Zoe Alcock ticket 165830 |
+1 Suzanne Taylor ticket 168139 |
+1 Aidan Dockery ticket 170150 wants to disable swipe |
Fixed in ProPhoto 6.21.0 |
On an iPad, for instance, when viewing at an orientation/size where the user has indicated that they don't want the mobile menu visible, the user can still swipe to see the mobile menu. This swipe action should be disabled when the mobile menu is hidden.
The text was updated successfully, but these errors were encountered: