Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests are flaky #20

Closed
spion opened this issue Jan 4, 2015 · 2 comments
Closed

Tests are flaky #20

spion opened this issue Jan 4, 2015 · 2 comments
Milestone
1.0

Comments

@spion
Copy link
Contributor

spion commented Jan 4, 2015

The current tests are flaky; they rely on timings and sometimes randomly pass or fail. Need to identify which timeouts can be replaced with events on the eventemitter; implement those events and update the tests
@spion spion added this to the 1.0 milestone Jan 16, 2015
@Sinewyk Sinewyk mentioned this issue May 27, 2015
Closed
@spion
Copy link
Contributor Author

spion commented Sep 10, 2015

The test bugs have been fixed, however any new additions will likely demand a refactor. That would be a good opportunity to add unit tests which should be much faster and less flaky.

@spion
Copy link
Contributor Author

spion commented Oct 26, 2015

Unit tests haven't been added, however the tests are a lot more stable now

@spion spion closed this as completed Oct 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@spion