New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PATCH: Collaboration diagramm exceeds the page border in LaTeX generated pdf files (Origin: bugzilla #618632) #3775

Closed
doxygen opened this Issue Jul 2, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@doxygen
Owner

doxygen commented Jul 2, 2018

status RESOLVED severity normal in component general for ---
Reported in version 1.6.3-SVN on platform Other
Assigned to: Dimitri van Heesch

On 2010-05-14 14:26:57 +0000, Jan Schmidt wrote:

Overview:

Collaboration diagramms which have both a width larger than maxWidth AND an
height larger than maxHeight exceed the page border if width/maxWidth is less than height/maxHeight.

Patch:

in src/dot.cpp:2020
in function QCString DotClassGraph::writeGraph(...)

instead of:

  if (width>maxWidth)
  {
    out << "\\includegraphics[width=" << maxWidth << "pt]";
  }
  else if (height>maxHeight)
  {
    out << "\\includegraphics[height=" << maxHeight << "pt]";
  }
  else
  {
    out << "\\includegraphics[width=" << width << "pt]";
  }

write this:

  if ( (width>maxWidth) || (height>maxHeight) )
  {

if ( (float)width/(float)maxWidth > (float)height/(float)maxHeight )
{
out << "\includegraphics[width=" << maxWidth << "pt]";
}
else
{
out << "\includegraphics[height=" << maxHeight << "pt]";
}
}
else
{
out << "\includegraphics[width=" << width << "pt]";
}

On 2010-05-16 10:01:48 +0000, Dimitri van Heesch wrote:

Thanks for the patch.
I'm currently reworking dot.cpp, and I'll include your patch while I'm at it.

On 2010-06-15 11:22:25 +0000, Dimitri van Heesch wrote:

This bug was previously marked ASSIGNED, which means it should be fixed in
doxygen version 1.7.0. Please verify if this is indeed the case. Reopen the
bug if you think it is not fixed and please include any additional information
that you think can be relevant.

@doxygen doxygen closed this Jul 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment