Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmatched push/pop of generator state can lead to refman.tex not being generated (Origin: bugzilla #689720) #4979

Closed
doxygen opened this issue Jul 2, 2018 · 0 comments

Comments

@doxygen
Copy link
Owner

doxygen commented Jul 2, 2018

status RESOLVED severity normal in component general for ---
Reported in version 1.8.2-SVN on platform Other
Assigned to: Dimitri van Heesch

On 2012-12-05 17:37:55 +0000, Gareth McCaughan wrote:

Since r812 (1.8.0-20120429) the following has been the case: The implementation ClassDef::writeInheritedMemberDeclarations does: ol.pushGeneratorState(); do some things; ol.popGeneratorState(). However, within the "do some things" code it is possible for writeInheritedMemberDeclarations to return early, in which case the pop never happens and the generator state isn't properly unwound.

I haven't attempted to figure out the details of how it all worked out in the particular case I encountered, but the effect was that when refman.tex is supposed to be created, although the LaTeX output generator has supposedly just been enabled, it isn't really because the generator state stack is all confused, and refman.tex never gets created. I would imagine the same underlying error could cause other problems in other situations.

Explicitly calling ol.popGeneratorState() before the early return from ClassDef::writeInheritedMemberDeclarations appears to fix the problem for me, but I haven't looked into it deeply enough to be 100% certain that no further changes are called for.

On 2012-12-11 19:58:10 +0000, Dimitri van Heesch wrote:

Confirmed. Should be fixed in the next subversion update.

On 2012-12-26 16:09:01 +0000, Dimitri van Heesch wrote:

This bug was previously marked ASSIGNED, which means it should be fixed in
doxygen version 1.8.3. Please verify if this is indeed the case. Reopen the
bug if you think it is not fixed and please include any additional information
that you think can be relevant.

@doxygen doxygen closed this as completed Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant