New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize width in resize.js adds double width for a handle-bar (Origin: bugzilla #699218) #5155

Closed
doxygen opened this Issue Jul 2, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@doxygen
Owner

doxygen commented Jul 2, 2018

status RESOLVED severity normal in component general for ---
Reported in version 1.8.3.1-SVN on platform Other
Assigned to: Dimitri van Heesch

Original attachment names and IDs:

On 2013-04-29 12:34:55 +0000, Goran Rakic wrote:

Created attachment 242793
One line patch for resize.js

Default navtree.css adds 6px right padding to #side-nav for the handle-bar width.

That is why in file resize.js the result of $(sidenav).outerWidth() called from function resizeWidth() already includes the handle-bar width and we do not need to add additional 6px margin here.

On 2013-04-29 12:49:09 +0000, Dimitri van Heesch wrote:

Hi Goran,

Thanks for your patch. To better analyse the impact can you explain the problem that you see and which your patch fixes?

On which browsers did you test your patch?

On 2013-04-29 13:39:52 +0000, Goran Rakic wrote:

Created attachment 242799
Screenshot without a patch

On 2013-04-29 13:40:12 +0000, Goran Rakic wrote:

Created attachment 242800
Screenshot with a patch

On 2013-04-29 13:40:24 +0000, Goran Rakic wrote:

I am using "Google Chrome 27.0.1453.56 beta".

The issue is that $(sidenav).outerWidth() will include the #side-nav padding, set to 6px to match the handle-bar width. In resize.js on line 41 you are adding this 6px again making a gap.

Attaching the screenshots with and without a patch.

On 2013-04-29 14:27:45 +0000, Dimitri van Heesch wrote:

Thanks, it is clear now. I'll include the patch in the next subversion update.

On 2013-05-19 12:36:11 +0000, Dimitri van Heesch wrote:

This bug was previously marked ASSIGNED, which means it should be fixed in
doxygen version 1.8.4. Please verify if this is indeed the case. Reopen the
bug if you think it is not fixed and please include any additional information
that you think can be relevant.

@doxygen doxygen closed this Jul 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment