[PATCH] Fix potential copy and paste error in inputstring.cpp (Origin: bugzilla #730887)

[doxygen]

status RESOLVED severity normal in component general for ---
Reported in version 1.8.7-GIT on platform Other
Assigned to: Dimitri van Heesch

Original attachment names and IDs:

• fix.patch (ID 277386)

On 2014-05-28 12:57:18 +0000, Ettl Martin wrote:

Created attachment 277386
proposed fix

Please review the attached patch. It fixes a potential copy and paste error in inputstring.cpp.

Best regards and many thanks

Martin Ettl

On 2014-05-29 07:59:17 +0000, albert wrote:

I think the proposed change in the patch should be applied, currently only PROJECT_LOGO uses this feature. The PROJECT_LOGO is always visible so the setEnabled is always TRUE, but in future there might be settings that can be disabled and than this problem would occur.

@martin how did you find this problem, did you use any tools for it?

On 2014-05-30 07:10:15 +0000, Ettl Martin wrote:

Hi,
i habe found this issue during a code review. Do you know any tool that finds those kind of issues?

Best regards

Martin

On 2014-06-07 22:35:36 +0000, Dimitri van Heesch wrote:

Thanks, I'll include the patch in the next GIT update.

On 2014-08-21 17:15:13 +0000, Dimitri van Heesch wrote:

This bug was previously marked ASSIGNED, which means it should be fixed in
doxygen version 1.8.8. Please verify if this is indeed the case. Reopen the
bug if you think it is not fixed and please include any additional information
that you think can be relevant (preferrably in the form of a self-contained example).