Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH] Fix a potential null pointer dereference in src/memberdef.cpp (Origin: bugzilla #735477) #5565

Closed
doxygen opened this issue Jul 2, 2018 · 0 comments

Comments

@doxygen
Copy link
Owner

doxygen commented Jul 2, 2018

status RESOLVED severity normal in component general for ---
Reported in version 1.8.8-GIT on platform Other
Assigned to: Dimitri van Heesch

Original attachment names and IDs:

On 2014-08-26 19:56:50 +0000, Ettl Martin wrote:

Created attachment 284539
proposed fix

Please review the attached patch, it fixes a potential null pointer dereference in src/memberdef.cpp.

The statement mli.current() can return 0.
Here is a traceback:
The function current() looks as followed (qtools/qlist.h, line 146):
type *current() const { return (type *)QGListIterator::get(); }

The function QGlistIterator::get() (qtools/qglist.h, 253) looks as followed:

inline QCollection::Item QGListIterator::get() const
{
return curNode ? curNode->data : 0;
}

As you can see, it can return 0. This patch takes care of this potential issue.

Best regards and many thanks

Martin Ettl

On 2014-08-30 17:14:46 +0000, Dimitri van Heesch wrote:

Thanks, I'll include a variant of the patch in the next GIT update.

On 2014-12-25 16:03:31 +0000, Dimitri van Heesch wrote:

This bug was previously marked ASSIGNED, which means it should be fixed in
doxygen version 1.8.9. Please verify if this is indeed the case. Reopen the
bug if you think it is not fixed and please include any additional information
that you think can be relevant (preferrably in the form of a self-contained example).

@doxygen doxygen closed this as completed Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant