New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow ligatures in log output (Origin: bugzilla #761471) #5945

Closed
doxygen opened this Issue Jul 2, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@doxygen
Owner

doxygen commented Jul 2, 2018

status RESOLVED severity minor in component doxywizard for ---
Reported in version 1.8.9.1 on platform Other
Assigned to: Dimitri van Heesch

Original attachment names and IDs:

On 2016-02-02 19:31:18 +0000, Pander wrote:

Created attachment 320290
Unwanted ligatures

Please, do not allow ligatures, such as "�" for "fi", in log output. This is a common problem these days with many monospaced rendering and has to be disabled explicitly. See attachment for example.

On 2016-02-03 14:43:40 +0000, albert wrote:

I don't see this behavior on my, Window 7, system.
From the code I see:
m_outputLog = new QTextEdit;
m_outputLog->setReadOnly(true);
m_outputLog->setFontFamily(QString::fromLatin1("courier"));

So my guess is that the courier font cannot be found in your case.

Which platform are you using?

On 2016-02-03 16:14:48 +0000, Pander wrote:

Ubuntu latest and I have that font.

This is a common default setting on (HTML) text rendering that is highly undesirable when displaying text in monospaced font. That it shows fi ligatures indicates that there is very good font support, as these are special font features.

In CSS, this is fixed by

style='font-family: courier; -o-font-feature-settings: "liga" off; -o-font-variant-ligatures: none; -moz-font-feature-settings: "liga" off; -moz-font-variant-ligatures: none; -webkit-font-feature-settings: "liga" off; -webkit-font-variant-ligatures: none; font-feature-settings: "liga" off; font-variant-ligatures: none; '

On 2016-02-04 19:15:20 +0000, Dimitri van Heesch wrote:

@pander: Maybe it would be a fix to use

m_outputLog = new QPlainTextEdit

instead of

m_outputLog = new QTextEdit.

in addon/doxywizard/doxywizard.cpp

Can you try if that helps?

On 2016-02-04 22:11:59 +0000, Pander wrote:

For this project, I am only a user. Please ask somebody else to reproduce and confirm the proposed fix. Thanks.

On 2016-02-06 19:03:14 +0000, albert wrote:

On RHEL6 this problem didn't show but the text was displayed in italics.
Changing to QPlainTextEdit didn't solve the problem.
With QTextBrowser it was possible to overcome the problem.

I've just pushed a proposed patch to github (pull request 451)

On 2016-09-03 11:13:12 +0000, albert wrote:

Code has been integrated in master branch on github

On 2016-09-05 13:45:53 +0000, Dimitri van Heesch wrote:

This bug was previously marked ASSIGNED, which means it should be fixed in
doxygen version 1.8.12. Please verify if this is indeed the case. Reopen the
bug if you think it is not fixed and please include any additional information
that you think can be relevant (preferably in the form of a self-contained example).

@doxygen doxygen closed this Jul 2, 2018

@doxygen doxygen added the doxywizard label Jul 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment