Remove logger 3rd party library

[vanniktech]

Quickly looking at the code it seems like there's only one log statement:

kotlin-csv/src/commonMain/kotlin/com/github/doyaaaaaken/kotlincsv/client/CsvFileReader.kt

Line 48 in 8108e5b

logger.info { "skip miss matched row. [csv row num = ${idx + 1}, fields num = ${row.size}, fields num of first row = $fieldsNumInRow]" }

Do we really need to pull an entire library for logging?

kotlin-csv/build.gradle.kts

Line 50 in ed7a678

implementation("io.github.microutils:kotlin-logging:2.0.11")

I'm an Android user and currently that log would go basically nowhere.

[vanniktech]

I'd propose to remove that log statement. If you're using skipMissMatchedRow you're kind of expecting this behavior.

[doyaaaaaken]

Thanks for the feedback. 👍 I'll consider it in a short time.

[doyaaaaaken]

Hi, @vanniktech, thank you for your useful feedback.

In conclusion, I would like to leave this library dependency as it is.

At first, I think It would be nice to replace the dependency for kotlin-logger with that for slf4j, but I can't do it because kotlin-csv is multiplatform library.
Then, I consider simply removing kotlin-logger, but decide to keep it because logging is an important element for CSV read/write because it is a complex use case that requires debugging.

[vanniktech]

kotlin-csv is multiplatform library.

and that's good!

Then, I consider simply removing kotlin-logger, but decide to keep it because logging is an important element for CSV read/write because it is a complex use case that requires debugging.

But then would you want to use a debugger instead of a log statement that goes possibly nowhere, right?

[doyaaaaaken]

I see what you're saying, but this log message is very important information for users of the skipMissMatchedRow option.
As of now, I use the kotlin-logger at only one statement, but we would probably use it at other statements in the future.
So, I would like to leave it for now.

[vanniktech]

Okay but then would not it be better to have our own Logger interface which - if you want logging, you can pass your own instance and to the logging you'd need - and otherwise you're not bothered by it?

[doyaaaaaken]

Sounds like a good idea.
If you have an image of how you would implement it, I would welcome a pull request if you like.

[doyaaaaaken]

Released in version 1.4