Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python API and PEP 8 #153

Open
doyubkim opened this issue Mar 8, 2018 · 13 comments
Open

Python API and PEP 8 #153

doyubkim opened this issue Mar 8, 2018 · 13 comments

Comments

@doyubkim
Copy link
Owner

doyubkim commented Mar 8, 2018

Current Python API follows corresponding C++ API naming convention which partially breaks PEP 8 (ex. function names). Other frameworks such as TensorFlow for instance, seems to follow language-specific guidelines. That would be ideal for Jet framework as well. However, changing the naming convention will break the API obviously, so it should target for v2.

@doyubkim
Copy link
Owner Author

doyubkim commented Oct 7, 2018

@utilForever volunteered to work on this issue!

@utilForever, currently dev-v2-gpu is the main dev branch for the v2 release. This contains new C++ APIs (such as new vector/matrix implementations) so it would be great to start from there. You can branch out from dev-v2-gpu and create something like dev-v2-gpu-pep8, make changes, and raise PR against dev-v2-gpu (not the master of course).

@utilForever
Copy link
Collaborator

@doyubkim Alright. I'll start working today.

@doyubkim doyubkim added p1 and removed p2 labels Oct 7, 2018
@doyubkim
Copy link
Owner Author

@utilForever Also checking in to see where we're at on this. Thanks again for taking this effort!

@utilForever
Copy link
Collaborator

@doyubkim Thanks. I'll work on this weekend. Please understand that my health is not very good.

@doyubkim
Copy link
Owner Author

Same as the other issue: @utilForever I am terribly sorry to hear that :( You should take a good break and not look at any codes. I will take this issue and raise a PR. Please take a good rest and get well soon!

@doyubkim doyubkim assigned doyubkim and unassigned utilForever Oct 18, 2018
@utilForever
Copy link
Collaborator

Same as the other issue: @doyubkim Thanks. I'm OK now. So, please take this issue to me. 😄

@utilForever utilForever assigned utilForever and unassigned doyubkim Oct 19, 2018
@doyubkim
Copy link
Owner Author

@utilForever I am currently working on unifying redundant 2-D and 3-D codes and this will introduce quite a lot of changes in the Python binding lib. If you haven't started working on this issue, I recommend not starting it until the unifying work is completed.

@utilForever
Copy link
Collaborator

@doyubkim I'm already working on this issue. I'll consider your unifying work. 🎉

@doyubkim
Copy link
Owner Author

doyubkim commented Dec 1, 2018

@utilForever the latest dev branch is now merged into the dev-v2-gpu branch. This contains some breaking changes in Python APIs so you may need to adapt to it. What's the latest status of this PEP8 work?

@utilForever
Copy link
Collaborator

@doyubkim I'm now finished with exception of some grids. However, I'm working on changing the structure from 3 days ago.

@doyubkim
Copy link
Owner Author

doyubkim commented Dec 1, 2018

@utilForever thanks for the update!

@utilForever
Copy link
Collaborator

@doyubkim Update: My work is almost finished. Can I do a pull request to dev-v2-gpu branch?

@doyubkim
Copy link
Owner Author

Thanks for the update! Yes, that should be the target branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants