New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ImplicitTriangleMesh3 and marchingCubes to Python API #218
Conversation
This PR is motivated by Issue #191. |
Codecov Report
@@ Coverage Diff @@
## master #218 +/- ##
=======================================
Coverage 88.15% 88.15%
=======================================
Files 547 547
Lines 36618 36618
=======================================
Hits 32279 32279
Misses 4339 4339
Continue to review full report at Codecov.
|
The simulator does not correctly save OBJ. They are 0 bytes in size. |
@PavelBlend that’s strange. What is your Python version? Where did you executed the script? Will try to reproduce. |
I ran apic_example03.py |
Interesting. Let me try it on a Windows machine. |
I'll try it today. I use Windows 10 Enterprise 64bit / Python 3.7. |
I checked in blender. And I saw that the meshes are written correctly. |
I've tested with a Windows machine and still works fine for me. Did you put the example script somewhere else? Empty obj files might be caused by empty sim since it couldn't find |
I'm sorry. Bunny.obj was packed in the archive. Everything works correctly. |
@utilForever, let me know if this PR looks fine to you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for your work.
I'm sorry. I was very busy due to year-end party and parent's house visit. |
No worries. Happy holidays! |
This revision adds/fixes Python API for
ImplicitTriangleMesh3
andmarchingCubes
. It also adds new Python example,apic_example03.py
, to demonstrate new/fixed features.