Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ImplicitTriangleMesh3 and marchingCubes to Python API #218

Merged
merged 1 commit into from Dec 29, 2018

Conversation

doyubkim
Copy link
Owner

This revision adds/fixes Python API for ImplicitTriangleMesh3 and marchingCubes. It also adds new Python example, apic_example03.py, to demonstrate new/fixed features.

@doyubkim
Copy link
Owner Author

This PR is motivated by Issue #191.

@codecov-io
Copy link

Codecov Report

Merging #218 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #218   +/-   ##
=======================================
  Coverage   88.15%   88.15%           
=======================================
  Files         547      547           
  Lines       36618    36618           
=======================================
  Hits        32279    32279           
  Misses       4339     4339
Impacted Files Coverage Δ
include/jet/implicit_triangle_mesh3.h 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c1aba4...5f0191c. Read the comment docs.

@PavelBlend
Copy link
Contributor

The simulator does not correctly save OBJ. They are 0 bytes in size.

@doyubkim
Copy link
Owner Author

@PavelBlend that’s strange. What is your Python version? Where did you executed the script? Will try to reproduce.

@PavelBlend
Copy link
Contributor

I ran apic_example03.py
Python version = 3.7.0 windows 64 bit

@doyubkim
Copy link
Owner Author

Interesting. Let me try it on a Windows machine.

@utilForever
Copy link
Collaborator

I'll try it today. I use Windows 10 Enterprise 64bit / Python 3.7.

@PavelBlend
Copy link
Contributor

I checked in blender. And I saw that the meshes are written correctly.
Maybe the problem is in the example, and not in the API?

@doyubkim
Copy link
Owner Author

I've tested with a Windows machine and still works fine for me. Did you put the example script somewhere else? Empty obj files might be caused by empty sim since it couldn't find bunny.obj.

@PavelBlend
Copy link
Contributor

I'm sorry. Bunny.obj was packed in the archive. Everything works correctly.

@doyubkim
Copy link
Owner Author

@utilForever, let me know if this PR looks fine to you.

@doyubkim doyubkim mentioned this pull request Dec 29, 2018
@doyubkim doyubkim merged commit 1d8b746 into master Dec 29, 2018
@doyubkim doyubkim deleted the issue_191 branch December 29, 2018 18:30
Copy link
Collaborator

@utilForever utilForever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your work.

@utilForever
Copy link
Collaborator

I'm sorry. I was very busy due to year-end party and parent's house visit.

@doyubkim
Copy link
Owner Author

No worries. Happy holidays!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants