2.0 #143
Merged
2.0 #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- old parameters is still used as as a default is no prop is sent
hartzis
reviewed
Jul 14, 2019
README.md
Outdated
|
|
||
| __useRecaptchaNet__: If google.com is blocked, you can set `useRecaptchaNet` to `true` so that the component uses recaptcha.net instead. | ||
|
|
||
| __removeOnUnmount__: If you plan to change the lang dynamically, `removeOnUnmount` should probably be `true`. This unloads the google recaptcha script on `componetWillUnmount` to allow for a new google recaptcha script to load next time the reCAPTCHA component is used to facilitate a new language if needed. | ||
| __removeOnUnmount__: *REMOVED* This was only useful for the lang changes. Lang is now changed through |
There was a problem hiding this comment.
REMOVED This was only useful for the lang changes. Lang is now changed through the hl prop.
|
Thoughts on removing the need for |
hartzis
reviewed
Jul 14, 2019
|
Is it time to include a hook? |
So recaptcha.net support needs to be defined quite early as it currently stands, I wonder if there is a way we can have that without the global options.
Like react-hooks? I'm open to it, I haven't had much time to toy with them unfortunately |
|
@hartzis published as 2.0.0-rc.1! I removed lang completely :). Also added a small upgrade guide. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thinking we can do some clean ups now that hl is a supported render prop.
I also added 12 in the CI.
Anything else you think we should add for 2.0?