Remove timeout removal, remove component unmount

[hartzis]

Attempt to fix #171.

Additionally:

• remove the reset() call on unmount as it may be the root cause of uncaught (in promise) timeout #103.
• The reset() may also not have been necessary
  • Issue Error: ReCAPTCHA has already been rendered in this element when rendering page for second time #55 was specific to a react error using the same ref
  • The fix for Error: ReCAPTCHA has already been rendered in this element when rendering page for second time #55 with Remove rendered DOM on unmount #73 included making a new div for each explicitRender which is probably all that is sufficient for the fix
• add a new forceReset method that calls grecaptcha.reset() without needing a widgetId
  • this could be used if users experience errors related to Error: ReCAPTCHA has already been rendered in this element when rendering page for second time #55 again 🤷

@dozoisch could you possibly publish an alpha/beta of this that I can test?

📓 If this does all work and simplifies things it will possibly require a major? 🤔

[dozoisch]

Yep will publish today

[dozoisch]

Published from this branch 3.0.0-alpha.1

[hartzis]

@dozoisch Thank you thank you!

I was able to validate that #171 appears to be fixed using the example the author created

• https://codesandbox.io/s/dark-glitter-9v9u4?file=/src/index.js

I also validated against our two other codesandbox examples that this change doesn't break anything

• normal: https://codesandbox.io/s/dark-glitter-9v9u4?file=/src/index.js
• invisible: https://codesandbox.io/s/react-google-recaptcha-210-example-invisible-forked-b76f9?file=/src/index.js

Curious about your thoughts on the release. I'm starting to think that this change is actually backwards compatible, maybe a major is too conservative?

Maybe only a minor and if it does break we can hotfix with a bug fix?

[anajavi]

If you are releasing a new major, the react dependency could be bumped to 16.14.0 too.

That would enable the use of the new jsx transform

[dozoisch]

@hartzis sorry for delay.. im tempted to still go for major given the change underneath and take the opportunity to do other major bumps like that react bump

[hartzis]

@dozoisch i think either approach is fine, but the major is definitely safer.

i also like the thought @anajavi has about bumping the react version

[romainleduc]

Hello, this PR seems to have solved an issue I'm currently experiencing.
Is it expected to merge soon ?

Currently I have to proceed in this way to see the recaptcha badge displayed

const formReCAPTCHA = () => {
  const [load, setLoad] = useState(false);
  
  useEffect(() => {
    setTimeout(() => {
      setLoad(true);
    }, 5000);
  }, []);
  
  return (
    <form>
      {load &&
        <ReCAPTCHA
          ref={recaptchaRef}
          size="invisible"
          sitekey="6LeIxAcTAAAAAJcZVRqyHh71UMIEGNQ_MXjiZKhI"
        />  
      }
    </form>
  );
}

Thank you :)

[dozoisch]

@romainleduc for the time being you can set your package.json version to 3.0.0-alpha.1 to have this fix!