Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builds fail when attempting usesClearText=true #164

Closed
2 of 3 tasks
munsterlander opened this issue Sep 20, 2019 · 1 comment
Closed
2 of 3 tasks

Builds fail when attempting usesClearText=true #164

munsterlander opened this issue Sep 20, 2019 · 1 comment

Comments

@munsterlander
Copy link

I'm submitting a ... (check one with "x"):

  • bug report
  • feature request
  • documentation issue

Bug report

Current behavior:

When attempting the following:

<custom-config-file target="AndroidManifest.xml" parent="./" mode="add">
        <application android:usesCleartextTraffic="true"/>
    </custom-config-file>

The built AndroidManifest file is incomplete and ultimately while a build is successful, the app can't be registered upon installation.

Expected behavior:

AndroidManifest.xml should contain:

<application android:usesClearText="true"....

On a side note, it could be I am just configuring this wrong, but the docs didn't show this example, so that is why I marked it as a possible documentation issue, of which, I would be happy to update and do a PR on, if I can get this solved.

Thank you all!

@munsterlander
Copy link
Author

Well disregard this. I have spent 3 days working on this and low and behold, finally figured it out. I was calling it wrong:

<edit-config file="app/src/main/AndroidManifest.xml" mode="merge" target="/manifest/application">
      <application android:usesCleartextTraffic="true" />
  </edit-config>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant