Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the plugin before 'cordova platform add' will give 'cannot find module ...' errors #23

Closed
nick-adriaenssens opened this issue Jan 19, 2016 · 3 comments

Comments

@nick-adriaenssens
Copy link

2 error examples I got:

Error: Cannot find module 'tostr'
Error: Cannot find module 'elementtree'

The plugin works fine if I add the plugin after cordova platform add
Is this necessary or is there something else wrong?

@dpa99c
Copy link
Owner

dpa99c commented Jan 21, 2016

Seems that the after_plugin_install hook, which the plugin uses to execute its dependency resolution script, does not run if the plugin is added to a project before a platform is added. I've updated the plugin to also run the dependency resolution script on after_platform_add hook. v1.1.11 of the plugin is now on the git master branch and also published to npm. This resolved the issue for me - please can you confirm it does the trick for you?

@nick-adriaenssens
Copy link
Author

I tried 1.1.11 but it did not seem to work. I currently have not enough time to go any deeper on this issue, but I will get on it whenever I can.

@dpa99c dpa99c closed this as completed in 4d6ce89 Feb 8, 2016
@nick-adriaenssens
Copy link
Author

I can confirm It's working now. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants