Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote configuration attribute for values not being respected #40

Closed
trigoesrodrigo opened this issue Mar 3, 2016 · 3 comments
Closed

Comments

@trigoesrodrigo
Copy link

When applying quote="none" or quote="key" to an ios preference, the value is always quoted when it shouldn't.

I think the error could be on https://github.com/dpa99c/cordova-custom-config/blob/1.2.5/hooks/applyCustomConfig.js#L400 . The value written is always quoteEscape(item.value) when it should be value.

@dpa99c
Copy link
Owner

dpa99c commented Mar 3, 2016

oops, yes you are right. looks like I forgot to change line 400 to block["buildSettings"][name] = value;.
Will fix, bump version and push to npm. thanks for reporting it 👍

@dpa99c dpa99c closed this as completed in 8d977d5 Mar 3, 2016
@dpa99c
Copy link
Owner

dpa99c commented Mar 3, 2016

pushed to npm as 1.2.6

@trigoesrodrigo
Copy link
Author

Wow that was fast!

Thank you! ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants