Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No config applied in version 2.0.2 #64

Closed
LorisZ opened this issue Jul 18, 2016 · 2 comments
Closed

No config applied in version 2.0.2 #64

LorisZ opened this issue Jul 18, 2016 · 2 comments

Comments

@LorisZ
Copy link

LorisZ commented Jul 18, 2016

We use this plugin to change parameters for AndroidManifest.xml and it worked just fine in 2.0.0. But using the version 2.0.2 it stopped working; the config was missing completely in the AndroidManifest.xml found inside platforms.

short excerpt very similar to our config we use:

<platform name="android">
        ...
        <config-file target="AndroidManifest.xml" parent="/*">
            <uses-permission android:name="android.permission.CAMERA" />
            <uses-feature android:name="android.hardware.camera" />
            ...
        </config-file>
        <config-file target="AndroidManifest.xml" parent="./application">
            <activity android:label="@string/title_activity_photo_gps" android:name="com.example.PhotoGpsActivity" android:screenOrientation="portrait" android:windowActionBar="false"/>
            <activity android:name="com.example.NfcActivity" android:theme="@android:style/Theme.Black.NoTitleBar" />
        </config-file>
    </platform>

Can someone reproduce this bug? Or was there some change to the syntax/behavior? I wouldn't expect such thing to happen on a patch level change.

@dpa99c
Copy link
Owner

dpa99c commented Jul 18, 2016

Using your example config above, I can reproduce an issue where the Cordova activity is being overwritten with custom activities. I have tracked this down to a bug introduced by pull request #48. I'll fix this and push out a patch release as 2.0.3

@dpa99c dpa99c closed this as completed in 0f10f18 Jul 18, 2016
@dpa99c
Copy link
Owner

dpa99c commented Jul 18, 2016

Please check that cordova-custom-config@2.0.3 resolves your issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants