-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New 4.0.0 rating(result) is returning 0, dialog not opening. #26
Comments
For android, here is my fix:
|
The same thing happened to me on Android. I'm receiving Packages version:
Code usage:
Calling this method by:
|
Will take a look into this when I get a moment |
I'm integrating this module and I'm also seeing the same 0 result for android, as described above in the first example, with the same code. |
Just published a fix for this issue in v4.0.1 See updated documentation and example project for reference. |
Bug report
CHECKLIST
[x ] I have read the issue reporting guidelines
[x ] I confirm this is a suspected bug or issue that will affect other users
Bring attention back to: Unable to have the rating() function working for android #25 - I posted more details at bottom of this closed issue with what is happening.
Current behavior:
This is breaking on v4.0.0 on Android versions 7 - 10, but older version 3.1.1 still works on v7 - 10. I don't have an Android 11 device (yet) to test on so I don't know the behavior for v11.
Result is returning value 0, not opening dialog but also causing external app review to not launch.
LaunchReview.rating(function(result) { // result = 0, unexpected }
Expected behavior:
On Android, using old v3.1.1 advanced code or the new v4.0.0 advanced code, rating
result
returns value while also not prompting for dialog box or launching external app store review. Condition0
is not an expected response.Steps to reproduce:
To fix, I had to add:
The text was updated successfully, but these errors were encountered: