Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android doesn't open the Google Play In-App Reviews APIs of the app. #30

Closed
5 tasks done
delciopolanco opened this issue Jul 23, 2022 · 1 comment
Closed
5 tasks done

Comments

@delciopolanco
Copy link

delciopolanco commented Jul 23, 2022

Bug report

CHECKLIST

  • I have reproduced the issue using the example projector provided the necessary information to reproduce the issue.
  • I have read the documentation thoroughly and it does not help solve my issue.
  • I have checked that no similar issues (open or closed) already exist.

Current behavior:

When the modal prompt is shown there is nothing to review, this plugin only redirects to the apps's main page app store.

Expected behavior:

We should review the app as described in the google play in-app API.

Steps to reproduce:

  1. npm install @awesome-cordova-plugins/launch-review
  2. npm install cordova-launch-review
  3. cordova plugin add cordova-launch-review
  4. add LaunchReview to the app Module.
  5. Launch the plugin.

or use the example provided by modifying the Id on the launch function like the following:

function launchreview(){
LaunchReview.launch(function (){
showAlert("Successfully launched review app");
}, function (err){
showAlert("Error launching review app: " + err);
}, 'com.cbord.get');
}

Screenshots

Environment information

  • Cordova CLI version
    • 11.0.0
  • Cordova platform version
    • cordova platform ls
  • Plugins & versions installed in project (including this plugin)
    • cordova plugin ls
  • Dev machine OS and version, e.g.
    • OSX

Runtime issue

  • Device details
    • e.g. iPhone X, Samsung Galaxy S8, iPhone X Simulator, Pixel XL Emulator
  • OS details
    • e.g. iOS 12.2, Android 9.0

Android build issue:

  • Node JS version
    • v14.18.1
  • Gradle version
    • gradle-7.2
  • Target Android SDK version
    • android:targetSdkVersion in AndroidManifest.xml
  • Android SDK details
    • sdkmanager --list | sed -e '/Available Packages/q'

Related code:

insert any relevant code here such as plugin API calls / input parameters

Console output

/Users/x/Library/Android/sdk ➜ cordova-launch-review-example git:(master) cordova run android --stacktrace Checking Java JDK and Android SDK versions ANDROID_SDK_ROOT=/Users/x/Library/Android/sdk (recommended setting) ANDROID_HOME=/Users/x/Library/Android/sdk (DEPRECATED) Using Android SDK: /Users/x/Library/Android/sdk Subproject Path: CordovaLib Subproject Path: app Warning: Mapping new ns http://schemas.android.com/repository/android/common/02 to old ns http://schemas.android.com/repository/android/common/01 Warning: Mapping new ns http://schemas.android.com/repository/android/generic/02 to old ns http://schemas.android.com/repository/android/generic/01 Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/addon2/02 to old ns http://schemas.android.com/sdk/android/repo/addon2/01 Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/repository2/02 to old ns http://schemas.android.com/sdk/android/repo/repository2/01 Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/sys-img2/02 to old ns http://schemas.android.com/sdk/android/repo/sys-img2/01 > Task :CordovaLib:compileDebugJavaWithJavac FAILED

FAILURE: Build failed with an exception.

  • What went wrong:
    Execution failed for task ':CordovaLib:compileDebugJavaWithJavac'.

Could not find tools.jar. Please check that /Library/Internet Plug-Ins/JavaAppletPlugin.plugin/Contents/Home contains a valid JDK installation.

  • Try:
    Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

  • Get more help at https://help.gradle.org

Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/6.5/userguide/command_line_interface.html#sec:command_line_warnings

BUILD FAILED in 2s
19 actionable tasks: 3 executed, 16 up-to-date
Command failed with exit code 1: /Users/x/Projects/company/POCS/cordova-launch-review-example/platforms/android/gradlew cdvBuildDebug -b /Users/x/Projects/company/POCS/cordova-launch-review-example/platforms/android/build.gradle


// Paste any relevant JS/native console output here

function launchreview(){
    LaunchReview.launch(function (){
        showAlert("Successfully launched review app");
    }, function (err){
        showAlert("Error launching review app: " + err);
    }, 'com.cbord.get');
}



Other information:

Please update graddle version if possible.

@delciopolanco delciopolanco changed the title Android doesn't open the Google Play In-App Reviews API Android doesn't open the Google Play In-App Reviews APIs of the app. Jul 23, 2022
@delciopolanco
Copy link
Author

This is how is supposed to work on dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant