Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Custom location for GoogleService-Info.plist #452

Closed
zdm opened this issue Jul 14, 2020 · 6 comments
Closed

[FEATURE] Custom location for GoogleService-Info.plist #452

zdm opened this issue Jul 14, 2020 · 6 comments
Labels
feature request New feature request

Comments

@zdm
Copy link

zdm commented Jul 14, 2020

Hi,
I need to store all files, related to the ios platform, in resources/ios subdirectory.
So, I added file copy instruction to config.xml

<resource-file src="resources/ios/GoogleService-Info.plist" />

But it conflicts with the default firebasex behavior.
When I run cordova build ios it dies with error about conflicting resources.

Is it possible to respect user customized settings and apply defaults only if there is no user configuration defined?

Thank you.

@dpa99c
Copy link
Owner

dpa99c commented Jul 14, 2020

Attempting to detect if GoogleService-Info.plist has been deployed via another source is non-trivial since the execution order of plugin hook scripts is non-deterministic.
I can see no reason why you should need to reference GoogleService-Info.plist directly from the config.xml: if you place it in the project root directory, this plugin will deploy it to the iOS platform project.

@dpa99c dpa99c closed this as completed Jul 14, 2020
@zdm
Copy link
Author

zdm commented Jul 14, 2020

It is good practice, when file in the project are placed in directories with the logical sense.
GoogleService-Info.plist is related only to ios platform and should be placed near other ios resources.
Maybe you can add option where we can specify GoogleService-Info.plist location?
If this is not very hard.
Thank you,

@dpa99c
Copy link
Owner

dpa99c commented Jul 14, 2020

OK, this can be added as a feature request but it is not high on my priority list however I will consider accepting a PR which implements it for both the Android and iOS platforms.

@dpa99c dpa99c reopened this Jul 14, 2020
@dpa99c dpa99c changed the title Custom location for GoogleService-Info.plist [FEATURE] Custom location for GoogleService-Info.plist Jul 14, 2020
@dpa99c dpa99c added the feature request New feature request label Jul 14, 2020
@zdm
Copy link
Author

zdm commented Jul 14, 2020

By the way, google-services.json works for me without conflicts when it is located in resources/android/google-services.json.

@zdm
Copy link
Author

zdm commented Jul 18, 2020

I created PR, that closes this issue. Could you please review it?

@dpa99c
Copy link
Owner

dpa99c commented Jul 23, 2020

Resolved by merge of PR #465

@dpa99c dpa99c closed this as completed Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature request
Projects
None yet
Development

No branches or pull requests

2 participants