Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically enable Sign in with Apple Entitlement (its possible, in fact, easy!) #485

Closed
slothentic opened this issue Aug 17, 2020 · 1 comment
Labels
documentation Documentation issue feature request New feature request

Comments

@slothentic
Copy link

slothentic commented Aug 17, 2020

This issue is half documentation issue, half feature request. The documentation states: "Note: AFAIK there is currently no way to automate the addition of this capability" with regards to enabling Sign In with Apple entitlement: https://github.com/dpa99c/cordova-plugin-firebasex#ios-3

Maybe at the time of writing it was not possible, but it is now trivial to enable this entitlement automatically. I've created a plugin to do so: https://github.com/findmate/cordova-plugin-enable-applesignin ... It's just a few lines added in plugin.xml

I've been testing with this, and when you remove/add platform, it will correctly set the capability, one less manual thing to worry about!

It would be great to include this capability automatically, or at least mention the plugin in the docs so people don't have to remember to manually enable this capability.

@dpa99c
Copy link
Owner

dpa99c commented Sep 11, 2020

Maybe this entitlement was always there since Sign In with Apple was released and I just missed it but could've sworn I looked for it when implementing this...
Anyway thanks for pointing it out - will add it to the config.xml

@dpa99c dpa99c added documentation Documentation issue feature request New feature request ready for release Something has been implemented and is awaiting release to npm labels Sep 14, 2020
@dpa99c dpa99c closed this as completed in 5967be1 Sep 15, 2020
@dpa99c dpa99c removed the ready for release Something has been implemented and is awaiting release to npm label Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation issue feature request New feature request
Projects
None yet
Development

No branches or pull requests

2 participants