Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails if preferred navigator app is uninstalled #153

Closed
dpa99c opened this issue Sep 6, 2017 · 2 comments
Closed

Fails if preferred navigator app is uninstalled #153

dpa99c opened this issue Sep 6, 2017 · 2 comments
Labels

Comments

@dpa99c
Copy link
Owner

dpa99c commented Sep 6, 2017

Since v4 of the plugin, by default the built-in UI behaviour will ask users if they want to remember their selected app to use next time, rather than asking them each time. However, if they choose to remember their choice, and subsequently uninstall their preferred app (bit of an edge case, but possible), then the plugin currently continues to attempt to launch the uninstalled app, without first checking if it's still installed.

The result is, not only does the navigator app obviously not launch, but (on Android at least) neither the success or error callback is invoked. It looks like the native Android layer is catching the exception, but not passing it on to the error callback:

LaunchNavigator[native]: Exception occurred: No Activity found to handle Intent { act=android.intent.action.VIEW dat=lyft://ridetype?id=lyft&destination[latitude]=53.4807593&destination[longitude]=-2.2426305&pickup[latitude]=51.5073509&pickup[longitude]=-0.1277583 }
@dpa99c dpa99c added the bug label Sep 6, 2017
@dpa99c
Copy link
Owner Author

dpa99c commented Sep 13, 2017

Fixed by a7e2e0c which is on dev awaiting release

@dpa99c
Copy link
Owner Author

dpa99c commented Sep 18, 2017

Published in v4.0.5

@dpa99c dpa99c closed this as completed Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant