Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require one meaningful comment #17

Closed
lacabra opened this issue Feb 26, 2021 · 3 comments
Closed

Require one meaningful comment #17

lacabra opened this issue Feb 26, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@lacabra
Copy link
Collaborator

lacabra commented Feb 26, 2021

Require at least one "meaningful comment" before the submission is processed to filter out submissions that don't add value.

The very basic and minimum implementation for this feature would be to check whether there is at least one non-empty comment field in the entire form, and prevent the user from submitting the form unless that requirement is met. The "non-empty" can be further enhanced with additional checks. We are open to suggestions on how to implement the requirement to be "meaningful".

@lacabra lacabra added the enhancement New feature or request label Feb 26, 2021
@lacabra lacabra self-assigned this Feb 26, 2021
@lacabra lacabra added the good first issue Good for newcomers label Apr 23, 2021
@vaishnavi-ch
Copy link
Contributor

@lacabra can I work on this issue?

@lacabra lacabra assigned vaishnavi-ch and unassigned lacabra Apr 24, 2021
@vaishnavi-ch
Copy link
Contributor

vaishnavi-ch commented Apr 26, 2021

@lacabra I have completed the first requirement i.e check whether there is at least one non-empty comment field in the entire form and prevent the user, Kindly let me know if it looks fine and the changes to be made.
For the meaningful part, can u suggest some requirements for it?.

@lacabra
Copy link
Collaborator Author

lacabra commented Apr 26, 2021

Well, my only observation is that a meaningful comment has to have a minimum length that is significantly longer than 0. For example if someone says Yes, the length matches your check of being greater than 0, but that is not meaningful; so I would pick up a threshold of minimum length that is greater than the current 0. But beyond that I agree it is very hard to assess meaningfulness programatically. Set that predefined length as a constant towards the top of the file so that we can modify it easily in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants