This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
change css layout for theme menu #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -627,7 +627,6 @@ line-height: 14px; | |||
| } | |||
| .thumbs-list li { | |||
| display: inline-block; | |||
| float: left; | |||
There was a problem hiding this comment.
This float property was overriding the natural behavior of display: inline-block, which produces the desired behavior.
|
This branch has been deployed to staging for the purposes of reviewing this PR. You can see the theme menu in action here: http://staging.dp.la/exhibitions/exhibits/show/breadandroses |
|
Yay! Thanks @AudreyAltman. |
anarchivist
added a commit
that referenced
this pull request
Jun 9, 2015
change css layout for theme menu
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the formatting of the theme menu on on exhibitions. It addresses issue #7818 https://issues.dp.la/issues/7818
This removes CSS formatting that requires theme menus to have an even number of items in order to render properly. It alters the css so that the menus will render responsively, creating rows of items based on the width of the browser window. The variable heights of the items (caused by different theme title lengths) will not adversely affect the layout.