Support file extension-specific configuration

[midgleyc]

Thanks for making this -- it's a lot faster than prettier straight.

Unfortunately I can't port my config over. Prettier supports automatically reading config from a .editorconfig file, and I'm using that to use single quotes in .ts files and double quotes elsewhere (e.g. SCSS)

[*]
quote_type = double

[*.ts]
quote_type = single

Could you make it possible to specify prettier config for extensions individually? For example, something like:

{
  "prettier": {
    "singleQuote": false,
    "ts.singleQuote": true
  }
}

would translate the above (although there might be a better design).

[midgleyc]

Turns out prettier already supports this as

"singleQuote": false,
"overrides": {         
  "files": ["**/*.ts"],                                                                                  
  "options": {                                                                                           
    "singleQuote": true                                                                                  
  }                                                                                                      
}

This fails while parsing the object:

Error deserializing. Expected a boolean, string, or number in object property 'prettier -> overrides'

[dsherret]

Oh nice! I just need to implement dprint/dprint#530 in that case

[dsherret]

@midgleyc the "overrides" is supported now. Thanks for investigating that! You will need to upgrade to dprint 0.28 and dprint-plugin-prettier 0.8 though

[midgleyc]

Hi @dsherret . Thanks for the prompt update, I see that dprint is now reading the configuration file.

Unfortunately it is not working for me. I have put together a repository at https://github.com/midgleyc/dprint-prettier-test to show the issue: with the same config across prettier and dprint, prettier picks up the overrides, but it seems dprint does not.

[dsherret]

@midgleyc very sorry, I looked into this a bit just now and this definitely doesn't work. I must have flipped some condition in my head when I was testing it manually.

Looking into it more, it would be trivial to add this for stuff like **/*.js, but for globs like ./some-dir/**/*.js the current approach wouldn't work because the plugin doesn't have knowledge about what directory the config was loaded from. I'm thinking instead this should be built into dprint's CLI in order to have config based on a certain directory.

That said, I think for the purposes of this plugin doing extension level config should work well and will solve your use case. So I'm going to implement your original suggestion tonight and it will more easily have automated tests:

{
  "prettier": {
    "singleQuote": false,
    "ts.singleQuote": true
  }
}

Once again, my bad, but fix will be incoming soon tonight.

[dsherret]

Should be fixed now. Added a test and updated the readme: https://github.com/dprint/dprint-plugin-prettier#file-extension-specific-configuration

[midgleyc]

Works great now, thank you!