Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useSpaceSeparators and only have per ast node configuration #166

Closed
dsherret opened this issue Sep 23, 2019 · 1 comment
Closed

Comments

@dsherret
Copy link
Member

It would be better to remove the global useSpaceSeparators because I don't want certain behaviour by default.

For example, I like a space after an if keyword:

if (true) {}

But I don't like it after the function name:

function test () {
}

I also don't like it after the new keyword in constructor types and constructor function signatures:

new (...etc...)

useSpaceSeparators implies that there should be a space in both those cases.


Instead of the above, leave it to just having per AST node configuration.

Relates to #164.

@lazarljubenovic
Copy link

The spaces preferences really divide people in endless categories! I like spaces before parenthesis in function/method declarations, but not in calls.

function foo () { }
foo()

So that's another case 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants