Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider renaming arrowFunction.useParentheses: "always" #604

Closed
mrazauskas opened this issue Jan 19, 2024 · 1 comment
Closed

Consider renaming arrowFunction.useParentheses: "always" #604

mrazauskas opened this issue Jan 19, 2024 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@mrazauskas
Copy link

Currently the arrowFunction.useParentheses option is the only which takes "force" value. Renaming "force" to "always" would make the API more consistent.

Consider the following:

semiColons

  • "always" - Always uses semi-colons where applicable.

useBraces

  • "always" - Forces the use of braces. Will add them if they aren't used.
  • "preferNone" - Forces no braces when the header is one line and body is one line. Otherwise forces braces.

trailingCommas

  • "always" - Trailing commas should always be used.
  • "never" - Trailing commas should not be used.

jsx.multiLineParens

  • "always" - Always wrap JSX with parentheses if it spans multiple lines.
  • "never" - Never wrap JSX with parentheses.

And so on and on (;

@dsherret dsherret added bug Something isn't working good first issue Good for newcomers labels Jan 19, 2024
@mrazauskas
Copy link
Author

@dsherret Oh.. Just now I noticed that you added labels. To be sure: does that mean you would merge a PR with this change? I could try putting it together.

@mrazauskas mrazauskas closed this as not planned Won't fix, can't repro, duplicate, stale Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants