Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃檹馃徎 [feat/req] Allow specification of configuration file from VSCode config #12

Closed
rivy opened this issue Apr 16, 2021 · 3 comments
Labels
wontfix This will not be worked on

Comments

@rivy
Copy link

rivy commented Apr 16, 2021

It would be great to be able to specify a non-default configuration file to be used by the dprint formatter for a given workspace.

@dsherret
Copy link
Member

This is something I don鈥檛 want to do because it encourages using dprint without the default configuration, which is not a great experience, and it complicates all the implementations of editor plugins.

It sounds like implementing dprint/dprint#351 should meet your needs?

@rivy rivy changed the title 馃檹 [feat/req] Allow specification of configuration file from VSCode config 馃檹馃徎 [feat/req] Allow specification of configuration file from VSCode config Apr 16, 2021
@rivy
Copy link
Author

rivy commented Apr 16, 2021

It sounds like implementing dprint/dprint#351 should meet your needs?

Yes, that would fix it for me. I just wasn't sure which of the two (if either) would be more palatable to you, or, if other devs might have a different naming scheme in mind.

@dsherret
Copy link
Member

Sounds good! Closing in favour of that solution.

@dsherret dsherret added the wontfix This will not be worked on label Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants