Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support local node_modules installation in folders with spaces #33

Closed
luisherranz opened this issue May 17, 2022 · 2 comments · Fixed by #34
Closed

Support local node_modules installation in folders with spaces #33

luisherranz opened this issue May 17, 2022 · 2 comments · Fixed by #34

Comments

@luisherranz
Copy link
Contributor

It'd be great if the extension could pick up a local installation of dprint in node_modules (basically ./node_modules/.bin/dprint). That way, projects relying on package.json could declare the minimum version they need in the devDependencies property and people cloning the repository would not have to figure out how to do a global installation.
@luisherranz luisherranz mentioned this issue May 17, 2022
Closed
@luisherranz
Copy link
Contributor Author

It seems like support for this was added three days ago in 4ae6c68. I'll try to figure out why this was not working for me.

@luisherranz
Copy link
Contributor Author

luisherranz commented May 17, 2022 •
edited

Ok, my problem was related to the same spacing issue that prevented me from installing dprint with npm install in the first place. /Users/my name/dprint-project/node_modules/dprint/dprint fmt fails. It should be "/Users/my name/dprint-project/node_modules/dprint/dprint" fmt.

I'll open a PR.

@luisherranz luisherranz changed the title Support local node_modules installation Support local node_modules installation in folders with spaces May 17, 2022
@luisherranz luisherranz mentioned this issue May 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: support folders with spaces in npm luisherranz/dprint-vscode
1 participant
@luisherranz