Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement TryFrom<JsonValue> for serde::Value #5

Closed
bartlomieju opened this issue Jan 5, 2021 · 1 comment
Closed

Implement TryFrom<JsonValue> for serde::Value #5

bartlomieju opened this issue Jan 5, 2021 · 1 comment

Comments

@bartlomieju
Copy link

As per title, it'd be great to have this built into the library.
@bartlomieju bartlomieju mentioned this issue Jan 5, 2021
Merged
@dsherret dsherret mentioned this issue Apr 3, 2021
Merged
dsherret added a commit that referenced this issue Apr 3, 2021
@dsherret
feat: #5 - Add parse_to_serde_value under "serde" feature.
a2b2283
@dsherret
Copy link
Member

dsherret commented Apr 3, 2021

I added a new parse_to_serde_value function instead as it is slightly faster to go straight from a jsonc-parser AST to serde value rather than jsonc-parser AST -> jsonc-parser Value -> serde_json::Value.

@dsherret dsherret closed this as completed Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dsherret @bartlomieju