Add scale indexing #21
Conversation
| end | ||
|
|
||
| return Pitch(PitchClass(s.notes[n + 1]), s.notes[n + 1].octave + octave) | ||
| end |
There was a problem hiding this comment.
What else would make sense? That way positive and negative are symmetric around the tonic.
There was a problem hiding this comment.
1-based indexing is not only more common in Julia, but it also seems more common in music. If you poll 100 musicians with “what is the 5th note in the C major scale”, how many do you think would answer “A”?
There was a problem hiding this comment.
See e.g. https://en.m.wikipedia.org/wiki/Degree_(music) for the standard 1-based enumeration
There was a problem hiding this comment.
Nor do I understand the point of positive and negative indices being symmetric around the tonic. The intervals aren’t symmetric, nor are the musical functions of the notes.
There was a problem hiding this comment.
Good points, thanks! Let me rethink
No description provided.