Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporate some suggestions by John Verzani and more clean-up #32

Merged
merged 1 commit into from
May 22, 2015
Merged

Incorporate some suggestions by John Verzani and more clean-up #32

merged 1 commit into from
May 22, 2015

Conversation

dpsanders
Copy link
Member

No description provided.

@dpsanders
Copy link
Member Author

Incorporate some suggestions by @jverzani from https://github.com/jverzani/ImplicitEquations.jl/blob/master/src/intervals.jl:

  • inverse trig functions (asin, acos, atan) -- the implementation restricts the domain to [-1,1] for asin and acos
  • floor and ceil

It is not clear to me that <=, max and min make sense in the general context of intervals, so I have not included them. Do you need them, @jverzani?

@dpsanders dpsanders mentioned this pull request May 18, 2015
Closed
13 tasks
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 7b6c3d0 on suggestions_john_verzani into * on master*.

@jverzani
Copy link

I use <= and others, but they make more sense in my context where the answer is not boolean, but also has a possible "MAYBE" state. I'd leave out of your package if they don't make sense. Thanks!

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 4deb9dd on suggestions_john_verzani into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling d04485f on suggestions_john_verzani into * on master*.

@dpsanders dpsanders changed the title Incorporate some suggestions by John Verzani. Incorporate some suggestions by John Verzani and more clean-up May 18, 2015
@lbenet
Copy link
Member

lbenet commented May 20, 2015

This is ready to be merged, indeed, though better after #29

@dpsanders
Inverse trig functions and floor and ceil.
52b1c27 
Suggeestions by John Verzani.
Also parameterised the Jet object and rewrote the
root_finding tests.

Added inverse trig functions

Added tests for inverse trig functions

Added floor and ceil for intervals

Added tests for asin and acos when interval is not in domain. Added inverse trig functions in automatic_differentiation (need tests)

Parametrised Jet

Added :wide to newton tests. Added more contexts to newton tests

Remove Float from newton tests due to Travis
@coveralls
Copy link

Coverage Status

Coverage decreased (-4.1%) to 72.17% when pulling 52b1c27 on suggestions_john_verzani into 86b9f53 on master.

@dpsanders
Copy link
Member Author

Rebased and green. Merging.

dpsanders added a commit that referenced this pull request May 22, 2015
@dpsanders
Merge pull request #32 from dpsanders/suggestions_john_verzani
ae4e84a 
Incorporate some suggestions by John Verzani and more clean-up
@dpsanders dpsanders merged commit ae4e84a into master May 22, 2015
@dpsanders dpsanders deleted the suggestions_john_verzani branch May 22, 2015 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dpsanders @coveralls @jverzani @lbenet