Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Personnal updates for HTML, Clojure, JS and Org #12

Closed
Nollo opened this issue Sep 15, 2016 · 6 comments
Closed

Personnal updates for HTML, Clojure, JS and Org #12

Nollo opened this issue Sep 15, 2016 · 6 comments

Comments

@Nollo
Copy link
Contributor

Nollo commented Sep 15, 2016

EDIT: after I submitted the issue, I realize I should had put a PR instead, sorry :-)

Hello there!

This is my first contribution to this fantastic theme. I use Spacemacs and I did few customizations that fit my tastes, but I think it could be a global improvement.

These modifications are core and mode specifics. Core modifications are:

  • font-lock-constant-face
  • font-lock-builtin-face
  • font-lock-type-face

Let me know what do you think about it.

Clojure

Minor changes, but now you can see namespaces better

Clojure before...
Clojure Before
Clojure after!
Clojure After

Org

Some works for a better adaption of the theme to orgmode. I added some extra things like bigger headline or strike line for DONE.

Org before...
org-before
Org after!
org-after

HTML

Few tweaks for web mode, I find it more dracula-esque. I hesitate between the cyan color or the yellow color for attributes.

HTML before...
html-before
HTML after!
html-after

JS

Well, I didn't change specific things, but there are side effects, and it's still nice

JS before...
js-before
JS after!
js-after

@film42
Copy link
Contributor

film42 commented Sep 16, 2016

Looks great, throw up a PR!

@Nollo
Copy link
Contributor Author

Nollo commented Sep 18, 2016

Okay. Any other opinion before I do a PR ?

@film42
Copy link
Contributor

film42 commented Sep 18, 2016

I think the visual changes are fine. We'll probably get more input once a PR is open. We will also look at code changes in the PR. Thanks!

@Nollo
Copy link
Contributor Author

Nollo commented Sep 19, 2016

Done #13

@rajasimon
Copy link

Why this issue not closed?

@film42 film42 closed this as completed Nov 25, 2016
@film42
Copy link
Contributor

film42 commented Nov 25, 2016

Thanks @rajasimon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants