Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Troubles while including directories #33

Closed
ErwanAliasr1 opened this issue Dec 17, 2014 · 6 comments
Closed

Troubles while including directories #33

ErwanAliasr1 opened this issue Dec 17, 2014 · 6 comments

Comments

@ErwanAliasr1
Copy link

In the "while pop include_src src && pop include_target tgt; do" loop, you do

ddebug "Including directory: $src"
....
s=${initdir}/${tgt}/${i#$src/}

s could be a filename or a directory name depending on the file type.
In the case it's a file, you are doing
cp --reflink=auto --sparse=auto -fa -t "$s" "$i"

But in that case, it's wrong. We should use ${initdir}/${tgt} instead of $s isn't it ?

@ErwanAliasr1
Copy link
Author

If you agree on that, I'll do the PR

@ErwanAliasr1
Copy link
Author

Oh that solved https://review.openstack.org/#/c/142141/, making the PR.

@ErwanAliasr1
Copy link
Author

Rah missed my PR, please check issue #34....

@ErwanAliasr1
Copy link
Author

See #34

@haraldh
Copy link
Collaborator

haraldh commented Dec 17, 2014

Do you mean to use "--install" instead of "--include" ??

@haraldh
Copy link
Collaborator

haraldh commented Dec 17, 2014

ah, no. I see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants