Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Biceps:C11-C15 fail when Reports are duplicated. #110

Closed
ben-Draeger opened this issue Jun 22, 2023 · 0 comments · Fixed by #115
Closed

Biceps:C11-C15 fail when Reports are duplicated. #110

ben-Draeger opened this issue Jun 22, 2023 · 0 comments · Fixed by #115
Assignees
@ben-Draeger
Labels
bug Something isn't working

Comments

@ben-Draeger
Copy link
Collaborator

The test cases Biceps:C11-C15 fail when encountering duplicated Reports because they ensure that each Report contains changes. The test cases for Requirements Biceps:C5, Biceps:R5046_0, Biceps_B-284_0, Biceps:R0034_0, Biceps:R5003 can also fail when Reports are duplicated.

Unfortunately, when a test case subscribes to reports in addition to the general subscription initiated upon connecting, then SDCcc has multiple subscriptions for the same Report and hence those Reports are sent more than once.

Duplicating Reports is standard compliant and completely innocuous as they can be identified using their mdibVersion. Hence, our test cases should not fail in this case.
@ben-Draeger ben-Draeger added the bug Something isn't working label Jun 22, 2023
@ben-Draeger ben-Draeger self-assigned this Jun 22, 2023
@ben-Draeger ben-Draeger mentioned this issue Jul 4, 2023
Merged
12 tasks
@maximilianpilz maximilianpilz linked a pull request Jul 6, 2023 that will close this issue
Fix Issue #110: Biceps:C11-C15 fail when Reports are duplicated #115
Merged
12 tasks
ben-Draeger added a commit that referenced this issue Aug 21, 2023
@ben-Draeger @maximilianpilz @belagertem
Fix Issue #110: Biceps:C11-C15 fail when Reports are duplicated (#115)
a968396 
Fix Issue #110 .

Note: For Biceps:R0034_0, the report duplication issue could not be
reproduced. All other Tests were fixed.

Also fixed some compiler and checkstyle warnings.

# Checklist

The following aspects have been respected by the author of this pull
request, confirmed by both pull request assignee **and** reviewer:

* Adherence to coding conventions
  * [x] Pull Request Assignee
  * [x] Reviewer
* Adherence to javadoc conventions
  * [x] Pull Request Assignee
  * [x] Reviewer
* Changelog update (necessity checked and entry added or not added
respectively)
  * [x] Pull Request Assignee
  * [x] Reviewer
* README update (necessity checked and entry added or not added
respectively)
  * [x] Pull Request Assignee
  * [x] Reviewer
* config update (necessity checked and entry added or not added
respectively)
  * [x] Pull Request Assignee
  * [x] Reviewer
* SDCcc executable ran against a test device (if necessary)
  * [x] Pull Request Assignee
  * [x] Reviewer

---------

Co-authored-by: Maximilian Pilz <maximilian.pilz.git@gmail.com>
Co-authored-by: Malte Grebe-Lüth <104556762+belagertem@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ben-Draeger ben-Draeger

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Issue #110: Biceps:C11-C15 fail when Reports are duplicated ben-Draeger/SDCcc
1 participant
@ben-Draeger