Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Middlewares in Router #7

Closed
Dragas opened this issue Aug 7, 2017 · 0 comments
Closed

Middlewares in Router #7

Dragas opened this issue Aug 7, 2017 · 0 comments
Assignees
@Dragas
Labels
Breaking enhancement
Projects
Chatty/Core

Comments

@Dragas
Copy link
Owner

Dragas commented Aug 7, 2017 •
edited
Loading

Since router should only find and test requests against route, it shouldn't have middlewares in it. Instead, Input implementation should either return the request or null, if it doesn't pass the global middleware. Same with Output implementations. It should not accept a response, if it fails the test against specified middlewares.
@Dragas Dragas self-assigned this Aug 7, 2017
@Dragas Dragas added this to Backlog in Chatty/Core Aug 7, 2017
Dragas added a commit that referenced this issue Aug 19, 2017
@Dragas
fixes issue #7
509c3d2
@Dragas Dragas closed this as completed Aug 19, 2017
@Dragas Dragas moved this from Backlog to Done in Chatty/Core Aug 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dragas Dragas

Labels
Breaking enhancement
Projects
Chatty/Core
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Dragas