Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port existing tests to pytest #88

Closed
bdewilde opened this issue Apr 17, 2019 · 2 comments
Closed

port existing tests to pytest #88

bdewilde opened this issue Apr 17, 2019 · 2 comments

Comments

@bdewilde
Copy link
Collaborator

Currently, dragnet has unittest-based tests run via nose, but we could and probably should take advantage of a more modern and maintained testing framework like pytest. This is more of a chore than an issue, but just wanted to assess buy-in before writing any code.

Tasks:

  • port the tests into pytest-style
  • update testing dependencies in requirements.txt
  • bonus: get Travis CI running tests via pytest (side note: is the make test command in .travis.yml actually working??)
@b4hand
Copy link
Contributor

b4hand commented Apr 18, 2019

I'm in favor. The Travis build was working at one point in time, but I don't know if it's been checked since the project was moved

@bdewilde
Copy link
Collaborator Author

Going to close this since PR #89 was merged, but would be great to (separately) figure out why Travis CI doesn't seem to be running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants