Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.4 error #32

Closed
radu81 opened this issue Dec 10, 2020 · 2 comments
Closed

PHP 7.4 error #32

radu81 opened this issue Dec 10, 2020 · 2 comments

Comments

@radu81
Copy link

radu81 commented Dec 10, 2020

I am using this add-on on Elkarte 1.1.6 and I am doing some tests with PHP 7.4, after every page refresh I get this error on Elkarte log:
Type of error: General
Unknown Error: implode(): Passing glue string after array is deprecated. Swap the parameters
/index.php?action=mentions;sa=fetch;api=json;lastsent=0
File: /public/sources/subs/Optimus.class.php
Line: 290

289: | if (!empty($list_item))
290: | $context['insert_after_template'] .= implode($list_item, ',');
291: |  
292: | $context['insert_after_template'] .= ']

Is there any way to fix this? Thank you in advance

@dragomano
Copy link
Owner

Thanks, I will release a fix soon.

@radu81
Copy link
Author

radu81 commented Dec 11, 2020

Thank you dragomano.
In the meantime Spuds found a solution, change line 290 with
$context['insert_after_template'] .= implode(',', $list_item);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants