Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid VAT number doesn't mean that it's not real ;-) #38

Closed
michalsingr opened this issue Nov 6, 2017 · 1 comment · Fixed by #39
Closed

Invalid VAT number doesn't mean that it's not real ;-) #38

michalsingr opened this issue Nov 6, 2017 · 1 comment · Fixed by #39

Comments

@michalsingr
Copy link

if (! $this->validateVatSum($countryCode, $vatNumber)) {

This condition might be tricky... As my second test I've tried VAT CZ27082440 (the biggest e-shop in our country) which was evaluated by validateVatSum() method as invalid but it's existing and can be properly checked via VIES website.

I understand that the purpose of this is probably reducing requests to VEIS but IMHO I would not trust any EU administrator that a pattern (probably defined by law) for VAT number was fulfilled. As a result of this condition we get faked data, not real data from VIES.

Removing this condition or making it optional would help.

krzaczek added a commit to krzaczek/vies that referenced this issue Nov 6, 2017
 - fixes bug in CZ Validator
@krzaczek krzaczek mentioned this issue Nov 6, 2017
@krzaczek
Copy link
Collaborator

krzaczek commented Nov 6, 2017

@michalsingr Just pushed a patch to fix this issue. Maybe it's a good idea to add a switch that would allow to disable check-sum checking and relay 100% on the VIES API.

@DragonBe

DragonBe added a commit that referenced this issue Nov 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants