Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: manager router middlewares order #1385

Merged
merged 1 commit into from
Jun 15, 2022
Merged

fix: manager router middlewares order #1385

merged 1 commit into from
Jun 15, 2022

Conversation

gaius-qi
Copy link
Member

Signed-off-by: Gaius gaius.qi@gmail.com

Description

  • Fix manager router middlewares order.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added this to the v2.0.4 milestone Jun 15, 2022
@gaius-qi gaius-qi self-assigned this Jun 15, 2022
@gaius-qi gaius-qi requested a review from a team as a code owner June 15, 2022 03:35
@codecov-commenter
Copy link

Codecov Report

Merging #1385 (a308dc4) into main (afbd928) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1385      +/-   ##
==========================================
- Coverage   45.76%   45.75%   -0.01%     
==========================================
  Files         140      140              
  Lines       12035    12035              
==========================================
- Hits         5508     5507       -1     
- Misses       5900     5901       +1     
  Partials      627      627              
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 45.75% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_conductor.go 57.14% <0.00%> (-1.01%) ⬇️
...ent/daemon/peer/peertask_piecetask_synchronizer.go 48.91% <0.00%> (+2.16%) ⬆️
cdn/supervisor/progress/progress.go 96.87% <0.00%> (+6.25%) ⬆️

Copy link

@hyy0322 hyy0322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 95c92c2 into main Jun 15, 2022
@gaius-qi gaius-qi deleted the feature/route-auth branch June 15, 2022 04:31
gaius-qi added a commit that referenced this pull request Jun 28, 2023
Signed-off-by: Gaius <gaius.qi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants