Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: validate rate limiter #1392

Merged
merged 4 commits into from
Jun 16, 2022
Merged

fix: validate rate limiter #1392

merged 4 commits into from
Jun 16, 2022

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Jun 16, 2022 •
edited

Signed-off-by: Gaius gaius.qi@gmail.com

Description

  • Fix rate limiter burst size.

Related Issue

Fixes #1377

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added this to the v2.0.4 milestone Jun 16, 2022
@gaius-qi gaius-qi self-assigned this Jun 16, 2022
@gaius-qi gaius-qi requested a review from a team as a code owner June 16, 2022 07:25
@gaius-qi
fix: rate limiter burst size
cc3b740 
Signed-off-by: Gaius <gaius.qi@gmail.com>
@1037husterljx 1037husterljx self-requested a review June 16, 2022 07:34
1037husterljx
1037husterljx previously approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@1037husterljx 1037husterljx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the value of burst to prevent errors from being reported when the limit is too small

@gaius-qi
fix: rate limit
11a65b2 
Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi force-pushed the fix/rate-limiter branch 2 times, most recently from a139aa3 to e040749 Compare June 16, 2022 08:14
1037husterljx
1037husterljx previously approved these changes Jun 16, 2022
View reviewed changes
@gaius-qi
feat: validate rate limit
91e951f 
Signed-off-by: Gaius <gaius.qi@gmail.com>
jim3ma
jim3ma approved these changes Jun 16, 2022
View reviewed changes
Copy link
Member

@jim3ma jim3ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi changed the title fix: rate limiter burst size fix: validate rate limiter Jun 16, 2022
@gaius-qi gaius-qi merged commit 8a8eb25 into main Jun 16, 2022
@gaius-qi gaius-qi deleted the fix/rate-limiter branch June 16, 2022 08:38
@cutecutecat cutecutecat mentioned this pull request May 29, 2023
Open
gaius-qi added a commit that referenced this pull request Jun 28, 2023
@gaius-qi
fix: validate rate limiter (#1392)
9cabf76 
* fix: validate rate limiter

Signed-off-by: Gaius <gaius.qi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jim3ma jim3ma jim3ma approved these changes

@yxxhero yxxhero yxxhero approved these changes

@bigerous bigerous bigerous approved these changes

@1037husterljx 1037husterljx 1037husterljx left review comments

@imeoer imeoer Awaiting requested review from imeoer imeoer is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@244372610 244372610 Awaiting requested review from 244372610 244372610 is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

Assignees

@gaius-qi gaius-qi

Labels
client
Projects
None yet
Milestone
v2.0.4
Development

Successfully merging this pull request may close these issues.

dfget --limit doesn't work
5 participants
@gaius-qi @jim3ma @yxxhero @1037husterljx @bigerous