Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add seed peer for list scheduler grpc interface #1393

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Jun 16, 2022

Signed-off-by: Gaius gaius.qi@gmail.com

Description

  • Add seed peer for list scheduler grpc interface.

Related Issue

#1249

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added this to the v2.0.4 milestone Jun 16, 2022
@gaius-qi gaius-qi self-assigned this Jun 16, 2022
@gaius-qi gaius-qi requested a review from a team as a code owner June 16, 2022 09:58
@codecov-commenter
Copy link

Codecov Report

Merging #1393 (145b85b) into main (8a8eb25) will decrease coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1393      +/-   ##
==========================================
- Coverage   45.50%   45.40%   -0.11%     
==========================================
  Files         140      140              
  Lines       12059    12059              
==========================================
- Hits         5488     5475      -13     
- Misses       5946     5956      +10     
- Partials      625      628       +3     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 45.40% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/piece_broker.go 89.74% <0.00%> (-2.57%) ⬇️
client/daemon/peer/peertask_conductor.go 57.14% <0.00%> (-1.21%) ⬇️

Copy link
Member

@cndoit18 cndoit18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 3bec645 into main Jun 16, 2022
@gaius-qi gaius-qi deleted the feature/scheduler-seed-peer branch June 16, 2022 10:16
gaius-qi added a commit that referenced this pull request Jun 28, 2023
Signed-off-by: Gaius <gaius.qi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants