Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default repository does not exist and missing dependency containers #1395

Merged
merged 1 commit into from
Jun 16, 2022
Merged

fix: default repository does not exist and missing dependency containers #1395

merged 1 commit into from
Jun 16, 2022

Conversation

LetFu
Copy link
Contributor

@LetFu LetFu commented Jun 16, 2022

Signed-off-by: Letfu letfu@outlook.com

Description

Dragonfly2 starts with dependencies on mysql and redis, but they do not exist
in the script. and the default mirror repository d7yio does not exist.
Also some of the containers that depend on it when starting may not be ready
yet, so I added --restart=always.

Related Issue

Motivation and Context

In my use of . /run.sh container I found some problems.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@LetFu LetFu requested a review from a team as a code owner June 16, 2022 11:56
@codecov-commenter
Copy link

Codecov Report

Merging #1395 (e114102) into main (be6380a) will decrease coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1395      +/-   ##
==========================================
- Coverage   45.62%   45.36%   -0.27%     
==========================================
  Files         140      140              
  Lines       12059    12059              
==========================================
- Hits         5502     5470      -32     
- Misses       5927     5960      +33     
+ Partials      630      629       -1     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 45.36% <ø> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_piecetask_poller.go 30.43% <0.00%> (-16.67%) ⬇️
client/daemon/peer/peertask_conductor.go 57.14% <0.00%> (-1.21%) ⬇️
scheduler/service/service.go 83.16% <0.00%> (+0.61%) ⬆️

Dragonfly2 starts with dependencies on mysql and redis, but they do not exist
in the script. and the default mirror repository d7yio does not exist.

Also some of the containers that depend on it when starting may not be ready
yet, so I added --restart=always.

Signed-off-by: LetFu <letfu@outlook.com>
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jim3ma jim3ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jim3ma jim3ma merged commit 689cf83 into dragonflyoss:main Jun 16, 2022
@LetFu LetFu deleted the fix/deployScript branch June 16, 2022 13:47
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
…ers (#1395)

Dragonfly2 starts with dependencies on mysql and redis, but they do not exist
in the script. and the default mirror repository d7yio does not exist.

Also some of the containers that depend on it when starting may not be ready
yet, so I added --restart=always.

Signed-off-by: LetFu <letfu@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants