Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dfdaemon add GetObject rest api #1398

Merged
merged 3 commits into from
Jun 17, 2022
Merged

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Jun 17, 2022

Description

  • Dfdaemon add GetObject rest api.

Related Issue

#1249

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: Gaius <gaius.qi@gmail.com>
Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added this to the v2.0.4 milestone Jun 17, 2022
@gaius-qi gaius-qi requested a review from a team as a code owner June 17, 2022 06:18
@gaius-qi gaius-qi self-assigned this Jun 17, 2022
@gaius-qi gaius-qi force-pushed the feature/objectstorage-service branch from 82c3f1e to 4245bbc Compare June 17, 2022 06:23
@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2022

Codecov Report

Merging #1398 (4245bbc) into main (be6380a) will decrease coverage by 0.17%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1398      +/-   ##
==========================================
- Coverage   45.62%   45.44%   -0.18%     
==========================================
  Files         140      140              
  Lines       12059    12062       +3     
==========================================
- Hits         5502     5482      -20     
- Misses       5927     5954      +27     
+ Partials      630      626       -4     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 45.44% <0.00%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/daemon.go 5.41% <0.00%> (-0.05%) ⬇️
client/daemon/peer/peertask_piecetask_poller.go 30.43% <0.00%> (-16.67%) ⬇️
client/daemon/peer/peertask_conductor.go 58.14% <0.00%> (-0.21%) ⬇️
...ent/daemon/peer/peertask_piecetask_synchronizer.go 47.61% <0.00%> (+2.16%) ⬆️

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi force-pushed the feature/objectstorage-service branch from 4245bbc to b2c5a99 Compare June 17, 2022 06:32
Copy link
Member

@jim3ma jim3ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit b705780 into main Jun 17, 2022
@gaius-qi gaius-qi deleted the feature/objectstorage-service branch June 17, 2022 06:58
Copy link

@hyy0322 hyy0322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gaius-qi added a commit that referenced this pull request Jun 28, 2023
* feat: dfdaemon add GetObject rest api

Signed-off-by: Gaius <gaius.qi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants