Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: scheduler announce task #1407

Merged
merged 2 commits into from
Jun 22, 2022
Merged

refactor: scheduler announce task #1407

merged 2 commits into from
Jun 22, 2022

Conversation

gaius-qi
Copy link
Member

Description

  • Refactor scheduler announce task.

Related Issue

#1249

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi
feat: scheduler announce normal task
c672a91 
Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added this to the v2.0.4 milestone Jun 22, 2022
@gaius-qi gaius-qi requested a review from a team as a code owner June 22, 2022 06:46
@gaius-qi gaius-qi self-assigned this Jun 22, 2022
@gaius-qi
feat: remove cid
ba9c45c 
Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi force-pushed the feature/scheduler-announce-task branch from 139d00d to ba9c45c Compare June 22, 2022 11:33
hyy0322
hyy0322 approved these changes Jun 22, 2022
View reviewed changes
Copy link

@hyy0322 hyy0322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaius-qi gaius-qi merged commit 2f07346 into main Jun 22, 2022
@gaius-qi gaius-qi deleted the feature/scheduler-announce-task branch June 22, 2022 11:59
gaius-qi added a commit that referenced this pull request Jun 28, 2023
@gaius-qi
refactor: scheduler announce task (#1407)
64f5e93 
* feat: scheduler announce normal task

Signed-off-by: Gaius <gaius.qi@gmail.com>

* feat: remove cid

Signed-off-by: Gaius <gaius.qi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yxxhero yxxhero yxxhero approved these changes

@hyy0322 hyy0322 hyy0322 approved these changes

@xujihui1985 xujihui1985 Awaiting requested review from xujihui1985 xujihui1985 is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@anjia0532 anjia0532 Awaiting requested review from anjia0532 anjia0532 is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@lucy-cl lucy-cl Awaiting requested review from lucy-cl lucy-cl is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

Assignees

@gaius-qi gaius-qi

Labels
client scheduler
Projects
None yet
Milestone
v2.0.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gaius-qi @yxxhero @hyy0322